Skip to content

Conversation

@cmp0xff
Copy link
Contributor

@cmp0xff cmp0xff commented Dec 15, 2025

Towards #1544

GroupBy and native types do not have default values in their type variables. Adding Any.

@cmp0xff cmp0xff requested a review from Dr-Irv December 16, 2025 16:23

def test_getattr() -> None:
check(assert_type(DF.resample("ME").col1, SeriesGroupBy), SeriesGroupBy)
check(assert_type(DF.resample("ME").col1, "SeriesGroupBy[Any, Any]"), SeriesGroupBy)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove [Any, Any] here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 471 to 474
assert_type(DF.resample("ME")["col1"], "SeriesGroupBy[Any, Any]"), SeriesGroupBy
)
check(
assert_type(DF.resample("ME")[["col1", "col2"]], "DataFrameGroupBy[Any, Any]"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove [Any, Any] here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmp0xff cmp0xff requested a review from Dr-Irv December 16, 2025 17:02
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cmp0xff

@Dr-Irv Dr-Irv merged commit 0f17f86 into pandas-dev:main Dec 16, 2025
16 checks passed
@cmp0xff cmp0xff deleted the feature/groupby-native branch December 16, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants